Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create permission library #26

Merged
merged 10 commits into from
Feb 29, 2024
Merged

Create permission library #26

merged 10 commits into from
Feb 29, 2024

Conversation

msimerson
Copy link
Contributor

@msimerson msimerson commented Feb 28, 2024 •
edited
Loading

fixes #20

Changes

  • conf: move session config into http.yml
  • permission: create,get,put,delete,destroy & tests
  • chore(config): guard against prototype pollution

@msimerson msimerson added this to the 3.0 milestone Feb 28, 2024
@msimerson msimerson self-assigned this Feb 28, 2024
@coveralls
Copy link

coveralls commented Feb 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8091527915

Details

  • 164 of 169 (97.04%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.6%) to 96.559%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/permission.js 154 159 96.86%
Files with Coverage Reduction New Missed Lines %
lib/permission.js 1 95.36%
Totals Coverage Status
Change from base Build 8083475100: 1.6%
Covered Lines: 1283
Relevant Lines: 1303
💛 - Coveralls

@msimerson msimerson merged commit a3734f9 into main Feb 29, 2024
16 checks passed
@msimerson msimerson deleted the permission branch February 29, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@msimerson msimerson

Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Write library to manipulate the DB for Permissions
2 participants
@msimerson @coveralls